lkml.org 
[lkml]   [2018]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v13 03/13] x86/cpufeatures: Add Intel-defined SGX leaf CPUID_12_EAX
On Mon, Aug 27, 2018 at 12:39:36PM -0700, Dave Hansen wrote:
> On 08/27/2018 11:53 AM, Jarkko Sakkinen wrote:
> > + /* Intel SGX features: level 0x00000012 */
> > + if (c->cpuid_level >= 0x00000012) {
> > + cpuid(0x00000012, &eax, &ebx, &ecx, &edx);
> > +
> > + c->x86_capability[CPUID_12_EAX] = eax;
> > + }
>
> I've given this specific bit of feedback at least once in the past.
> These patches are not ordered properly. You introduce this in the next
> patch:
>
> +#define SGX_CPUID 0x12

Yeah, my mistake probably when squashing fixups.

/Jarkko

\
 
 \ /
  Last update: 2018-08-28 09:25    [W:0.080 / U:3.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site