lkml.org 
[lkml]   [2018]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v13 03/13] x86/cpufeatures: Add Intel-defined SGX leaf CPUID_12_EAX
From
Date
On 08/27/2018 11:53 AM, Jarkko Sakkinen wrote:
> + /* Intel SGX features: level 0x00000012 */
> + if (c->cpuid_level >= 0x00000012) {
> + cpuid(0x00000012, &eax, &ebx, &ecx, &edx);
> +
> + c->x86_capability[CPUID_12_EAX] = eax;
> + }

I've given this specific bit of feedback at least once in the past.
These patches are not ordered properly. You introduce this in the next
patch:

+#define SGX_CPUID 0x12

\
 
 \ /
  Last update: 2018-08-27 21:40    [W:0.240 / U:0.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site