lkml.org 
[lkml]   [2018]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 1/4] staging: mt7621-mmc: Remove commented code for N_MSG
On Thu, Aug 23, 2018 at 10:58:09PM +0530, Nishad Kamdar wrote:
> This patch removes the dead code for N_MSG().
>
> Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> ---
> Changes in v5:
> - Remove commented code for N_MSG()
> ---
> drivers/staging/mt7621-mmc/dbg.h | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/staging/mt7621-mmc/dbg.h b/drivers/staging/mt7621-mmc/dbg.h
> index 2f2c56b73987..6f6b4505337f 100644
> --- a/drivers/staging/mt7621-mmc/dbg.h
> +++ b/drivers/staging/mt7621-mmc/dbg.h
> @@ -103,14 +103,6 @@ do { \
> #endif /* end of +++ */
>
> #define N_MSG(evt, fmt, args...)
> -/*
> -do { \
> - if ((DBG_EVT_##evt) & sd_debug_zone[host->id]) { \
> - printk(KERN_ERR TAG"%d -> "fmt" <- %s() : L<%d> PID<%s><0x%x>\n", \
> - host->id, ##args , __FUNCTION__, __LINE__, current->comm, current->pid); \
> - } \
> -} while(0)
> -*/
>

So what are we supposed to do with a macro that defines nothing now?
Please delete it and all users of it at the same time.

thanks,

greg k-h

\
 
 \ /
  Last update: 2018-08-27 20:06    [W:0.057 / U:6.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site