[lkml]   [2018]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH v2] drivers/thermal/tegra: Fix a double free on the device node
The function 'for_each_child_of_node' iterates over the node list by
dropping the of_node reference of the previous node.

Calling of_node_put() on the iterator is pointless and leads to an
inconsistent refcounting in addition to a double free. Remove it.

Acked-by: Jon Hunter <>
Signed-off-by: zhong jiang <>
v1->v2: According to Daniel's suggestion. I modify the subject and commit log.

drivers/thermal/tegra/soctherm.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
index ed28110..3aa55c9 100644
--- a/drivers/thermal/tegra/soctherm.c
+++ b/drivers/thermal/tegra/soctherm.c
@@ -980,7 +980,6 @@ static void soctherm_init_hw_throt_cdev(struct platform_device *pdev)
tcd = thermal_of_cooling_device_register(np_stcc,
(char *)name, ts,
- of_node_put(np_stcc);
if (IS_ERR_OR_NULL(tcd)) {
"throttle-cfg: %s: failed to register cooling device\n",
 \ /
  Last update: 2018-08-27 15:45    [W:0.032 / U:9.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site