lkml.org 
[lkml]   [2018]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] checkpatch: remove GCC_BINARY_CONSTANT warning
Date
This warning was there to avoid the use of 0bxxx values
as they are not supported by gcc prior to v4.3

Since commit cafa0010cd51f ("Raise the minimum required gcc
version to 4.6"), it's not an issue anymore and using
such values can increase readability of code.

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
---
scripts/checkpatch.pl | 11 -----------
1 file changed, 11 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 5219280bf7ff..d98650790722 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -4933,17 +4933,6 @@ sub process {
while ($line =~ m{($Constant|$Lval)}g) {
my $var = $1;

-#gcc binary extension
- if ($var =~ /^$Binary$/) {
- if (WARN("GCC_BINARY_CONSTANT",
- "Avoid gcc v4.3+ binary constant extension: <$var>\n" . $herecurr) &&
- $fix) {
- my $hexval = sprintf("0x%x", oct($var));
- $fixed[$fixlinenr] =~
- s/\b$var\b/$hexval/;
- }
- }
-
#CamelCase
if ($var !~ /^$Constant$/ &&
$var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
--
2.13.3
\
 
 \ /
  Last update: 2018-08-27 09:01    [W:0.027 / U:5.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site