lkml.org 
[lkml]   [2018]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning
From
Date
On Mon, 2018-08-20 at 10:06 +0200, Wolfram Sang wrote:
>
> > Some people still use those old machines, I'll give a try at fixing the
> > driver.
>
> I did this here a while ago [1] ("macintosh: therm_windtunnel: drop
> using attach adapter")...
>
> > Paul: Do you still have one of these machines ?
>
> ... but this was the main problem. I couldn't find anyone to test this.
> Even asked on PPC lists of various distributions.

Yeah this one is annoying because it's only used by one specific
machine model..

> Note that we did apply the same approach of patch [1] already in commit
> ac397c80de89 ("ALSA: ppc: keywest: drop using attach adapter"). This has
> been tested on HW. I also have a hack to make this driver probe on one
> of my ARM boards. Of course, no real HW present there, but shows that
> the new probing works at least there.
>
> This is very interesting timing, too. Because I wanted to use the
> tentative version jump to 5.0 to finally get rid of this deprecated
> feature independently of the discussion here. Which would have meant
> resending the patch and arguing we have enough indications that the
> patch [1] is sane. And then I could finally remove this callback.
>
> Thanks,
>
> Wolfram
>
> [1] http://patchwork.ozlabs.org/patch/461759/

Ok, worst case we can remove the driver and re-instate it back later if
somebody complains, but I'll try to chase a machine first.

Cheers,
Ben.


\
 
 \ /
  Last update: 2018-08-20 13:26    [W:0.117 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site