lkml.org 
[lkml]   [2018]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 1/5] mm/memory_hotplug: drop intermediate __offline_pages
From
Date
On 16.08.2018 13:44, Stephen Rothwell wrote:
> Hi David,
>
> On Thu, 16 Aug 2018 12:06:24 +0200 David Hildenbrand <david@redhat.com> wrote:
>>
>> -static int __ref __offline_pages(unsigned long start_pfn,
>> - unsigned long end_pfn)
>> +/* Must be protected by mem_hotplug_begin() or a device_lock */
>> +int offline_pages(unsigned long start_pfn, unsigned long nr_pages)
>
> You lose the __ref marking. Does this introduce warnings since
> offline_pages() calls (at least) zone_pcp_update() which is marked
> __meminit.
>

Good point, I'll recompile and in case there is a warning, keep the
__ref. Thanks!

--

Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2018-08-16 14:09    [W:0.167 / U:1.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site