[lkml]   [2018]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] IB/mlx5: fix uaccess beyond "count" in debugfs read/write handlers
On Fri, Jul 06, 2018 at 10:48:03PM +0200, Jann Horn wrote:
> In general, accessing userspace memory beyond the length of the supplied
> buffer in VFS read/write handlers can lead to both kernel memory corruption
> (via kernel_read()/kernel_write(), which can e.g. be triggered via
> sys_splice()) and privilege escalation inside userspace.
> In this case, the affected files are in debugfs (and should therefore only
> be accessible to root), and the read handlers check that *pos is zero
> (meaning that at least sys_splice() can't trigger kernel memory
> corruption). Because of the root requirement, this is not a security fix,
> but rather a cleanup.
> For the read handlers, fix it by using simple_read_from_buffer() instead of
> custom logic. Add min() calls to the write handlers.
> changed in v2:
> - also fix write handlers

No changelog in commit messages, please

> Fixes: 4a2da0b8c078 ("IB/mlx5: Add debug control parameters for congestion control")
> Fixes: e126ba97dba9 ("mlx5: Add driver for Mellanox Connect-IB adapters")
> Signed-off-by: Jann Horn <>
> ---
> drivers/infiniband/hw/mlx5/cong.c | 9 +--------
> drivers/infiniband/hw/mlx5/mr.c | 32 ++++++++-----------------------
> 2 files changed, 9 insertions(+), 32 deletions(-)

Reviewed-by: Leon Romanovsky <>
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2018-07-08 08:57    [W:0.040 / U:2.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site