[lkml]   [2018]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/3] [v2] m68k: mac: use time64_t in RTC handling
On Sun, 8 Jul 2018, Geert Uytterhoeven wrote:

> On Fri, Jun 22, 2018 at 10:55 AM Arnd Bergmann <> wrote:

> > I don't think anyone so far had a strong preference here, so I went
> > with what Mathieu suggested and kept the original Mac behavior, but
> > added the WARN_ON().
> So, is this safe to apply?
> Especially in light of the warnings seen by Meelis with the PPC version.

You mean, "can we apply this and avoid warning splats?"

Meelis's result says, "no".

I forget what date the RTC gets set to when the PMU/Cuda is reset but I
suspect that timezone arithmetic in either MacOS or Linux could cause it
to end up in 1969.

So I'd prefer to see the WARN_ON() removed.


 \ /
  Last update: 2018-07-08 13:44    [W:0.052 / U:1.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site