Messages in this thread |  | | From | Linus Torvalds <> | Date | Sun, 8 Jul 2018 11:31:16 -0700 | Subject | Re: Crypto Fixes for 4.18 |
| |
On Sun, Jul 8, 2018 at 9:20 AM Herbert Xu <herbert@gondor.apana.org.au> wrote: > > - Add missing RETs in x86 aegis/morus.
Side note - I queried earlier during the discussion about this: how was this code taken despite having clearly never tested on _anything_?
That's a serious question. Code that simply has never had any testing AT ALL should not have gotten in.
The use of 'int3' in padding showed the issue, but I don't believe the code could possibly have worked with the nops and fallthroughs.
Linus
|  |