[lkml]   [2018]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 4.14 44/61] mtd: rawnand: fix return value check for bad block status
4.14-stable review patch.  If anyone has any objections, please let me know.


From: Abhishek Sahu <>

commit e9893e6fa932f42c90c4ac5849fa9aa0f0f00a34 upstream.

Positive return value from read_oob() is making false BAD
blocks. For some of the NAND controllers, OOB bytes will be
protected with ECC and read_oob() will return number of bitflips.
If there is any bitflip in ECC protected OOB bytes for BAD block
status page, then that block is getting treated as BAD.

Fixes: c120e75e0e7d ("mtd: nand: use read_oob() instead of cmdfunc() for bad block check")
Cc: <>
Signed-off-by: Abhishek Sahu <>
Reviewed-by: Miquel Raynal <>
Signed-off-by: Boris Brezillon <>
[backported to 4.14.y]
Signed-off-by: Abhishek Sahu <>
Signed-off-by: Greg Kroah-Hartman <>

drivers/mtd/nand/nand_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -440,7 +440,7 @@ static int nand_block_bad(struct mtd_inf

for (; page < page_end; page++) {
res = chip->ecc.read_oob(mtd, chip, page);
- if (res)
+ if (res < 0)
return res;

bad = chip->oob_poi[chip->badblockpos];

 \ /
  Last update: 2018-07-06 07:56    [W:0.237 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site