lkml.org 
[lkml]   [2018]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCHv5 1/4] kbuild: Add build salt to the kernel and modules
From
Date
On 07/03/2018 08:59 PM, Masahiro Yamada wrote:
> Hi.
>
> Thanks for the update.
>
>
> 2018-07-04 8:34 GMT+09:00 Laura Abbott <labbott@redhat.com>:
>>
>> The build id generated from --build-id can be generated in several different
>> ways, with the default being the sha1 on the output of the linked file. For
>> distributions, it can be useful to make sure this ID is unique, even if the
>> actual file contents don't change. The easiest way to do this is to insert
>> a section with some data.
>>
>> Add an ELF note to both the kernel and module which contains some data based
>> off of a config option.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Signed-off-by: Laura Abbott <labbott@redhat.com>
>> ---
>> v5: I used S-o-b here since the majority of the code was written
>> already.
>
>
> I think Suggested-by is good enough.
> S-o-b is appended as a patch is passed from people to people.
>
> Anyway, this looks good except one bike-shed.
>
>> Please feel free to change the tag if you think it's not
>> appropriate. I also tweaked this to take an ascii string instead of just
>> a hex value since this makes things much easier on the distribution
>> side.
>> ---
>
>
>> diff --git a/init/Kconfig b/init/Kconfig
>> index 041f3a022122..8de789f40db9 100644
>> --- a/init/Kconfig
>> +++ b/init/Kconfig
>> @@ -107,6 +107,15 @@ config LOCALVERSION_AUTO
>>
>> which is done within the script "scripts/setlocalversion".)
>>
>> +config BUILD_SALT
>> + string "Build ID Salt"
>> + default "Linux"
>
>
> How about empty string ""
> for default?
>

Sure, seems to work fine.

Thanks,
Laura

\
 
 \ /
  Last update: 2018-07-05 21:21    [W:0.069 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site