lkml.org 
[lkml]   [2018]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] HID: debug: check length before copy_to_user()
On Mon, Jul 02, 2018 at 04:59:37PM -0700, Daniel Rosenberg wrote:
> If our length is greater than the size of the buffer, we
> overflow the buffer

Hmm...

How about this:
buf = list->hid_debug_buf;
if (list->tail < list->head) {
ret = simple_read_from_buffer(buffer, count, &list->head,
buf, HID_DEBUG_BUFSIZE);
if (ret < 0)
break;
if (list->head != buf + HID_DEBUG_BUFSIZE)
break;
list->head = 0;
}
n = simple_read_from_buffer(buffer + ret, count - ret, &list->head,
buf, list->tail);
if (n >= 0)
ret += n;
if (list->head == buf + HID_DEBUG_BUFSIZE)
list->head = 0;
instead?

\
 
 \ /
  Last update: 2018-07-05 02:48    [W:0.584 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site