lkml.org 
[lkml]   [2018]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v12 02/13] x86/sgx: add SGX definitions to cpufeature
On Tue, Jul 03, 2018 at 08:48:54PM +0200, Thomas Gleixner wrote:
> On Tue, 3 Jul 2018, Jarkko Sakkinen wrote:
>
> Subject: x86/sgx: add SGX definitions to cpufeature
>
> The prefix is bogus. Not everything you touch is SGX just because.
>
> The proper prefix is 'x86/cpufeatures:'
> The following sentence starts with an uppercase letter.
>
> And with the proper prefix the subject wants to be something like:
>
> x86/cpufeatures: Add SGX and SGX_LC CPU features
>
> > From: Kai Huang <kai.huang@linux.intel.com>
> >
> > Added X86_FEATURE_SGX and X86_FEATURE_SGX_LC definitions that define the
>
> Add the ...
>
> -> definitions that define
>
> That's redundant.
>
> > bits CPUID level 7 bits for determining whether the CPU supports SGX and
>
> bits ... bits ??
>
> > launch configuration other than the Intel proprietary key. If this the
> > case, IA32_SGXLEPUBKEYHASHn MSRs (0 < n < 4) are available for defining the
> > root key for enclaves.
> >
> > Signed-off-by: Kai Huang <kai.huang@linux.intel.com>
>
> Lacks your SOB
>
> Thanks,
>
> tglx

Thanks, will refine!

/Jarkko

\
 
 \ /
  Last update: 2018-07-04 19:25    [W:0.105 / U:5.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site