lkml.org 
[lkml]   [2018]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] thermal: ti-soc-thermal: remove dead code
On Tue, Jul 03, 2018 at 10:40:25AM +0530, Keerthy wrote:
>
>
> On Monday 02 July 2018 10:00 PM, Eduardo Valentin wrote:
> > Keerthy,
> >
> > On Fri, Jun 29, 2018 at 06:10:26PM +0200, Bartlomiej Zolnierkiewicz wrote:
> >>
> >> Hi,
> >>
> >> On Wednesday, May 02, 2018 03:20:35 PM Bartlomiej Zolnierkiewicz wrote:
> >>> Majority of this code (i.e. functions from ti-bandgap.c) has been
> >>> introduced in May 2013 by commit eb982001dbd8 ("thermal: introduce TI
> >>> SoC thermal driver"). Just remove it altogether (in case it is needed
> >>> it can be easily resurrected from git repo).
> >>>
> >>> While at it fix incorrect "not used" comments.
> >>>
> >>> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> >>> ---
> >>> drivers/thermal/ti-soc-thermal/dra752-bandgap.h | 68 ---
> >>> drivers/thermal/ti-soc-thermal/dra752-thermal-data.c | 65 ---
> >>> drivers/thermal/ti-soc-thermal/omap3-thermal-data.c | 6
> >>> drivers/thermal/ti-soc-thermal/omap4-thermal-data.c | 10
> >>> drivers/thermal/ti-soc-thermal/omap4xxx-bandgap.h | 10
> >>> drivers/thermal/ti-soc-thermal/omap5-thermal-data.c | 46 --
> >>> drivers/thermal/ti-soc-thermal/omap5xxx-bandgap.h | 41 --
> >>> drivers/thermal/ti-soc-thermal/ti-bandgap.c | 370 -------------------
> >>> drivers/thermal/ti-soc-thermal/ti-bandgap.h | 43 --
> >>> 9 files changed, 5 insertions(+), 654 deletions(-)
> >>
> >> Gentle ping.
> >>
> >> It would be great to see this patch in v4.19.
> >
> > Any objections on this removal / cleanup?
>
> Tested the patch on dra72-EVM.
> cpufreq cooling works well.
>
> Tested-by: Keerthy <j-keerthy@ti.com>
> Acked-by: Keerthy <j-keerthy@ti.com>

Thanks, queueing this cleanup.

>
> Thanks for the clean up Bartalomiej!
> >

\
 
 \ /
  Last update: 2018-07-04 18:01    [W:0.069 / U:11.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site