lkml.org 
[lkml]   [2018]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 4/4] clk: bd71837: Add driver for BD71837 PMIC clock
On Tue, Jun 26, 2018 at 11:13:19AM +0300, Matti Vaittinen wrote:
> On Mon, Jun 25, 2018 at 04:44:57PM -0700, Stephen Boyd wrote:
> > Quoting Matti Vaittinen (2018-06-12 01:23:54)
> > > On Tue, Jun 12, 2018 at 12:44:11AM -0700, Stephen Boyd wrote:
> > > > Quoting Matti Vaittinen (2018-06-04 06:19:13)

[snip]

> > > > > + if (rval) {
> > > > > + dev_err(&pdev->dev, "failed to register clkdev for bd71837");
> > > > > + goto err_clean_provider;
> > > > > + }
> > > > > +
> > > > > + platform_set_drvdata(pdev, c);
> > > > > +
> > > > > + return 0;
> > > > > +
> > > > > +err_clean_provider:
> > > > > + of_clk_del_provider(pdev->dev.parent->of_node);
> > > > > +err_out:
> > > > > + return rval;
> > > > > +}
> > > > > +
> > > > > +static int bd71837_clk_remove(struct platform_device *pdev)
> > > > > +{
> > > > > + if (pdev->dev.parent->of_node)
> > > > > + of_clk_del_provider(pdev->dev.parent->of_node);
> > > >
> > > > Use devm so this can go away. Or is devm not used because the parent
> > > > of_node is the provider? That's annoying.
> > >
> > > What would be the correct workaround for this?
> >
> > Smash the clk driver into the overall PMIC node. That should work. Or
> > possibly assign the same of_node to the child device when creating it?
> > I'm not sure if that causes some sort of problem with DT code though, so
> > it would be good to check with Rob H if that's a bad idea or not.
>
> 1. Assign MFD node to subdevice node in MFD when creating the cells.
> 2. Assign parent->of_node to dev.of_node in clk subdevice.
> 3. Create devm_of_clk_add_hw_provider_w_node() which does something
> like (not compiled pseudo) code below
>
> int devm_of_clk_add_hw_provider_w_node(struct device *dev,
> struct clk_hw *(*get)(struct of_phandle_args *clkspec,
> void *data),
> struct device_node *of_node,
> void *data)
> {
> struct device_node **ptr;
> int ret;
> ptr = devres_alloc(devm_of_clk_release_provider, sizeof(*ptr),
> GFP_KERNEL);
> if (!ptr)
> return -ENOMEM;
>
> *ptr = of_node;
> ret = of_clk_add_hw_provider(of_node, get, data);
> if (!ret)
> devres_add(dev, ptr);
> else
> devres_free(ptr);
>
> return ret;
> }
> EXPORT_SYMBOL_GPL(devm_of_clk_add_hw_provider_w_node);
>
> int devm_of_clk_add_hw_provider(struct device *dev,
> struct clk_hw *(*get)(struct of_phandle_args *clkspec,
> void *data),
> void *data)
> {
> return devm_of_clk_add_hw_provider_w_node(dev, get, dev->of_node,
> data);
> }
> EXPORT_SYMBOL_GPL(devm_of_clk_add_hw_provider);

just a friendly reminder, what's your opinion on adding this kind of
function (devm_of_clk_add_hw_provider_w_node)? or solutions 1/2? And are these options safe what comes to
reference counting of of_nodes?

Best regards
Matti Vaittinen

\
 
 \ /
  Last update: 2018-07-31 10:29    [W:0.059 / U:8.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site