lkml.org 
[lkml]   [2018]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 5/6] perf/core: Use ioctl to communicate driver configuration to kernel
On Tue, 3 Jul 2018 at 07:40, Jiri Olsa <jolsa@redhat.com> wrote:
>
> On Mon, Jul 02, 2018 at 04:33:29PM -0600, Mathieu Poirier wrote:
>
> SNIP
>
> > +static int
> > +perf_event_process_drv_config(struct perf_event *event, char *config_str)
> > +{
> > + int ret = -EINVAL;
> > + void *drv_data;
> > +
> > + /* Make sure ctx.mutex it held */
> > + lockdep_assert_held(&event->ctx->mutex);
> > +
> > + /* Children take their configuration from their parent */
> > + if (WARN_ON_ONCE(event->parent))
> > + goto out;
> > +
> > + drv_data = event->pmu->drv_config_validate(event, config_str);
> > + if (!drv_data)
> > + goto out;
>
> what's this check for? doc does not mention that,
> also the coresight callback does not return NULL
>

Very true - thanks for pointing this out.

Mathieu

> jirka

\
 
 \ /
  Last update: 2018-07-03 19:48    [W:0.113 / U:7.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site