[lkml]   [2018]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] mm/memblock: replace u64 with phys_addr_t where appropriate
On Tue, Jul 3, 2018 at 1:05 PM Mike Rapoport <> wrote:
> Most functions in memblock already use phys_addr_t to represent a physical
> address with __memblock_free_late() being an exception.
> This patch replaces u64 with phys_addr_t in __memblock_free_late() and
> switches several format strings from %llx to %pa to avoid casting from
> phys_addr_t to u64.
> CC: Michal Hocko <>
> CC: Matthew Wilcox <>
> Signed-off-by: Mike Rapoport <>

Looks good.

Reviewed-by: Pavel Tatashin <>

One minor thing that I would like to change in memblock.c is the
useage phys_addr_t for size. I understand the reasoning behind this
choice, but could we do something like:

typedef phys_addr_t phys_size_t;
It would be similar to resource_size_t. I just think the code and
function prototypes would look better with proper typing.

Thank you,

 \ /
  Last update: 2018-07-03 19:24    [W:0.217 / U:2.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site