lkml.org 
[lkml]   [2018]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] fsi/sbefifo: Add dependency on OF_ADDRESS
On Wed, Jul 04, 2018 at 12:23:20AM +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2018-07-03 at 06:43 -0700, Guenter Roeck wrote:
> > The driver calls of_platform_device_create() which is only available
> > if OF_ADDRESS is enabled. When building sparc64 images, this results
> > in
> >
> > ERROR: "of_platform_device_create" [drivers/fsi/fsi-sbefifo.ko] undefined!
> >
> > Fixes: 9f4a8a2d7f9d ("fsi/sbefifo: Add driver for the SBE FIFO")
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Thanks Guenter ! I'll include this into the fsi tree.
>
> (I was wondering what that kbuild report on sparc64 was about... I must
> have misread the code, I didn't realize of_platform_device_create
> wasn't under CONFIG_OF alone).
>
No worries; pretty much everyone using one of the affected functions
falls into that trap.

Guenter

\
 
 \ /
  Last update: 2018-07-03 17:40    [W:0.052 / U:3.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site