[lkml]   [2018]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/2] fs: ext4: use BUG_ON if writepage call comes from direct reclaim
On Tue, Jul 03, 2018 at 12:11:18PM +0800, Yang Shi wrote:
> direct reclaim doesn't write out filesystem page, only kswapd could do
> it. So, if the call comes from direct reclaim, it is definitely a bug.
> And, Mel Gormane also mentioned "Ultimately, this will be a BUG_ON." In
> commit 94054fa3fca1fd78db02cb3d68d5627120f0a1d4 ("xfs: warn if direct
> reclaim tries to writeback pages").
> Although it is for xfs, ext4 has the similar behavior, so elevate
> And, correct the comment accordingly.
> Cc: Mel Gorman <>
> Cc: "Theodore Ts'o" <>
> Cc: Andreas Dilger <>
> Signed-off-by: Yang Shi <>

What's the upside of crashing the kernel if the file sytsem can handle it?

- Ted

 \ /
  Last update: 2018-07-03 12:40    [W:0.105 / U:3.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site