lkml.org 
[lkml]   [2018]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset
* Faiz Abbas <faiz_abbas@ti.com> [180703 07:31]:
> Hi,
>
> On Tuesday 03 July 2018 12:37 PM, Tony Lindgren wrote:
> > * Tony Lindgren <tony@atomide.com> [180611 07:06]:
> >> * Faiz Abbas <faiz_abbas@ti.com> [180611 06:48]:
> >>> Hi,
> >>>
> >>> On Monday 11 June 2018 11:59 AM, Tony Lindgren wrote:
> >>>> * Faiz Abbas <faiz_abbas@ti.com> [180611 06:28]:
> >>>>> Great. I thought I completely misunderstood you. But I don't see what
> >>>>> adding another function will accomplish. A QUIRK flag used in the same
> >>>>> function would work well enough>
> >>>> Fine with me as long as the function stays simple for both
> >>>> syss and sysc reset.
> >>>>
> >>>
> >>>
> >>> In general a reset status bit being in sysstatus is the norm and it
> >>> being in sysconfig should be the "quirk" for which a flag needs to be
> >>> added. What do you think?
> >>
> >> Sure makes sense to me.
> >>
> >>> As an aside, naming bitshifts by the name of the platform they were
> >>> originally added in seems weird. There should be some generic mask
> >>> saying "soft reset is the 0th bit". Currently I am using
> >>> SYSC_OMAP4_SOFTRESET for a dra76x module. I guess it depends on how many
> >>> different sysconfig types we have.
> >>
> >> Sure we could have a macro for that.
> >
> > So what's the conclusion on this one? Are you going to do one
> > more version of the ti-sysc driver patch?
> >
>
> Yes. I have just now been able to get back to this. Will post a v4 by
> tomorrow.

OK thanks!

Tony

\
 
 \ /
  Last update: 2018-07-03 09:32    [W:0.183 / U:2.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site