lkml.org 
[lkml]   [2018]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/10] staging:rtl8192u: Refactor use of enum dm_dig_sta_e - Style
On Sat, Jul 28, 2018 at 12:28:18AM +0100, John Whitmore wrote:
> Refactor the use of the enumerated type dm_dig_sta_e, which is not
> actually used for type checking by the compiler.
>
> The enumerated type defines values for the enumeration, which are used
> by both dig_state and dig_highpwr_state, (members of the struct dig).
> Both of those variables were defined as being of type u8. This negates
> any usefulness of the use of the enumeration, (compiler type checking).
>
> To make use of the compiler's type-checking the two member variables,
> dig_state and dig_highpwr_state have been changed to being of type
> enum dm_dig_sta_e. The enumerated type has been moved above the
> struct dig definition so that the enumeration is already defined when
> compiler reaches the two types using the enumerated type.
>
> In addition the 'typedef' of the enumerated type has been removed to
> clear the checkpatch issue with declaring new types.
>
> These changes, whilst convoluted, are purely coding style in nature and
> should not impact runtime code execution.
>
> Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
> ---
> drivers/staging/rtl8192u/r8192U_dm.h | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_dm.h b/drivers/staging/rtl8192u/r8192U_dm.h
> index e86dda99c223..2444e1c1357b 100644
> --- a/drivers/staging/rtl8192u/r8192U_dm.h
> +++ b/drivers/staging/rtl8192u/r8192U_dm.h
> @@ -64,6 +64,13 @@
>
>
> /*------------------------------Define structure----------------------------*/
> +
> +enum dm_dig_sta_e {

Don't end an enum with "_e", as that's not needed at all.

thanks,

greg k-h

\
 
 \ /
  Last update: 2018-07-29 10:18    [W:0.067 / U:2.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site