lkml.org 
[lkml]   [2018]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4 1/1] Staging: octeon-usb: Using defined error codes and applying coding style
Hi,

Indeed there was a mix-up with patches i will send correction asap.
On Sun, 29 Jul 2018 at 23:21, Aaro Koskinen <aaro.koskinen@iki.fi> wrote:
>
> Hi,
>
> On Sun, Jul 29, 2018 at 05:33:38PM +0300, Georgios Tsotsos wrote:
> > diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> > index 3f44ac260eff..edf87d1b3609 100644
> > --- a/drivers/staging/octeon-usb/octeon-hcd.c
> > +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> > @@ -2590,6 +2590,7 @@ static void cvmx_usb_transfer_isoc(struct octeon_hcd *usb,
> > }
> > } else {
> > pipe->next_tx_frame += pipe->interval;
> > +
> > cvmx_usb_complete(usb, pipe, transaction, CVMX_USB_STATUS_OK);
>
> Unrelated whitespace change...
>
> > }
> > }
> > @@ -2624,16 +2625,16 @@ static int cvmx_usb_dma_halt(u32 hcchar_chena, u32 hcint_xfercompl,
> > cvmx_usb_write_csr32(usb,
> > CVMX_USBCX_HCCHARX(channel, usb->index),
> > usbc_hcchar.u32);
> > - return -1;
> > + return -EINVAL;
> > } else if (hcint_xfercompl) {
> > /*
> > * Successful IN/OUT with transfer complete.
> > * Channel halt isn't needed.
> > */
> > } else {
> > - dev_err(dev, "USB%d: Channel %d interrupt without halt\n",
> > + dev_ err(dev, "USB%d: Channel %d interrupt without halt\n",
> > usb->index, channel);
>
> ...also here. Does this even compile?
>
> > - return -1;
> > + return -EINVAL;
> > }
> >
> > return 0;
> > --
> > 2.16.4
>
> A.



--
Best regards!
Georgios Tsotsos
Greece-Evia-Chalkida
tsotsos@linux.com
skype: tsotsos
------------------------------------
Georgios Tsotsos
*Greece - Evia - Chalkida*
tsotsos[at]linux.com
skype: tsotsos

\
 
 \ /
  Last update: 2018-07-29 23:18    [W:0.077 / U:0.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site