lkml.org 
[lkml]   [2018]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] pinctrl/amd: fix gpio irq level in debugfs
On Tue, Jul 17, 2018 at 3:07 AM Daniel Kurtz <djkurtz@chromium.org> wrote:

> According to the AMD BKDG, the GPIO ActiveLevel bits (10:9) map to:
> 00 Active High
> 01 Active Low
> 10 Active on both edges iff LevelTrig (bit 8) == 0
> 11 Reserved
>
> The current code has a bug where it interprets 00 => Active Low, and
> 01 => Active High.
>
> Fix the bug, restrict "Active on both" to just the edge trigger case, and
> refactor a bit to make the logic more readable.
>
> Change-Id: Id7775ae4cb61d193fa7fbb83967a8c5a7cdd0de6

I stripped that off.

> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>

Patch applied!

Thanks for your fixing and attention to detail!

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2018-07-29 22:21    [W:0.070 / U:1.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site