lkml.org 
[lkml]   [2018]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] pwm: pwm-omap-dmtimer: fix probing problems by returning EPROBE_DEFER
From
Date
Hi,

> Am 29.07.2018 um 20:08 schrieb Ladislav Michl <ladis@linux-mips.org>:
>
> On Sun, Jul 29, 2018 at 08:32:41AM +0200, H. Nikolaus Schaller wrote:
>> Hi,
>>
>>> Am 28.07.2018 um 22:35 schrieb Ladislav Michl <ladis@linux-mips.org>:
>>>
>>> Hi Andreas,
>>>
>>> On Sat, Jul 28, 2018 at 06:59:14PM +0200, Andreas Kemnade wrote:
>>>> I got this in the kernel log:
>>>> [ 0.756042] omap-dmtimer-pwm dmtimer-pwm: dmtimer pdata structure NULL
>>>> [ 0.756134] omap-dmtimer-pwm: probe of dmtimer-pwm failed with error -22
>>>>
>>>> the probe function has to wait until omap_dm_timer_probe() in
>>>> clocksource/timer-ti-dm.c has initialized pdata, so defer probing
>>>
>>> There already is a patch by David Rivshin addressing the same issue...
>>
>> Here it is:
>>
>> https://patchwork.ozlabs.org/patch/943148/
>>
>> but hasn't arrived in linux-next.
>
> That's because there'll be v3.
>
>> But it is questionable if a driver should dev_info() about doing deferred probing.
>> IMHO, it should just do it which is how Andreas' patch works.
>
> See here: https://patchwork.ozlabs.org/patch/949659/

Ah, I see (neither Andreas nor me did follow the original discussions
and therefore came up independently with the same thoughts).

So we will wait for the v3.

BR and thanks,
Nikolaus

\
 
 \ /
  Last update: 2018-07-29 20:19    [W:0.069 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site