lkml.org 
[lkml]   [2018]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] Staging: octeon: Fixing coding style for minor notices.
From
Date
On Sun, 2018-07-29 at 17:43 +0300, Georgios Tsotsos wrote:
> Fixing coding style for a few lines that were reported to check from
> checkpatch.pl in minor cases for alignment and ending with parenthesis.
>
> Signed-off-by: Georgios Tsotsos <tsotsos@gmail.com>
> ---
> drivers/staging/octeon/ethernet.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
> index 9b15c9ed844b..1e258deecacc 100644
> --- a/drivers/staging/octeon/ethernet.c
> +++ b/drivers/staging/octeon/ethernet.c
> @@ -141,8 +141,8 @@ static void cvm_oct_periodic_worker(struct work_struct *work)
> if (priv->poll)
> priv->poll(cvm_oct_device[priv->port]);
>
> - cvm_oct_device[priv->port]->netdev_ops->ndo_get_stats(
> - cvm_oct_device[priv->port]);
> + cvm_oct_device[priv->port]->netdev_ops
> + ->ndo_get_stats(cvm_oct_device[priv->port]);
>
> if (!atomic_read(&cvm_oct_poll_queue_stopping))
> schedule_delayed_work(&priv->port_periodic_work, HZ);

Probably more sensible to use a temporary. Something like:
---
drivers/staging/octeon/ethernet.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
index 9b15c9ed844b..2febf1229587 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -137,12 +137,12 @@ static void cvm_oct_periodic_worker(struct work_struct *work)
struct octeon_ethernet *priv = container_of(work,
struct octeon_ethernet,
port_periodic_work.work);
+ struct net_device *ndev = cvm_oct_device[priv->port];

if (priv->poll)
- priv->poll(cvm_oct_device[priv->port]);
+ priv->poll(ndev);

- cvm_oct_device[priv->port]->netdev_ops->ndo_get_stats(
- cvm_oct_device[priv->port]);
+ ndev->netdev_ops->ndo_get_stats(ndev);

if (!atomic_read(&cvm_oct_poll_queue_stopping))
schedule_delayed_work(&priv->port_periodic_work, HZ);

\
 
 \ /
  Last update: 2018-07-29 19:34    [W:0.053 / U:24.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site