lkml.org 
[lkml]   [2018]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 10/14] arm64: dts: meson-axg: add linein codec
Hi Jerome,

On Tue, Jul 24, 2018 at 3:09 PM Jerome Brunet <jbrunet@baylibre.com> wrote:
>
> Add the es7241 analog to digital converter which is fed by the
> lienin jack of the s400
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> index 7489b88f27d7..fb101a1c6660 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> @@ -178,6 +178,16 @@
> gpios = <&gpio_speaker 2 0>;
> };
> };
> +
> + linein: audio-codec@0 {
there is a unit-address but no reg property - I am wondering if this is allowed?
for the regulators we're using regulator-<unique-name> instead of
regulator@<unique number>

(this applies to other patches in this series as well)

> + #sound-dai-cells = <0>;
> + compatible = "everest,es7241";
> + VDDA-supply = <&vcc_3v3>;
> + VDDP-supply = <&vcc_3v3>;
> + VDDD-supply = <&vcc_3v3>;
> + status = "okay";
> + sound-name-prefix = "Linein";
SPDIF output uses capital letters "SPDIFOUT"
I am not familiar with the sound subsystem (thus I'm not sure where
this shows up) so I am wondering if the naming should be consistent?


Regards
Martin

\
 
 \ /
  Last update: 2018-07-25 21:19    [W:0.112 / U:5.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site