lkml.org 
[lkml]   [2018]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 04/35] mtd: rawnand: denali: convert to nand_scan()
Hi Boris,

Boris Brezillon <boris.brezillon@bootlin.com> wrote on Wed, 25 Jul 2018
11:51:16 +0200:

> On Wed, 25 Jul 2018 18:42:44 +0900
> Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>
> >
> > You need to remove kfree(denali->buf)
> > from denali_remove(), right?
>
> Absolutely.
>
> >
> > void denali_remove(struct denali_nand_info *denali)
> > {
> > struct mtd_info *mtd = nand_to_mtd(&denali->nand);
> >
> > nand_release(mtd);
> > kfree(denali->buf); <---- REMOVE !!
> > denali_disable_irq(denali);
> > }
> >
> >
> > Otherwise, denali_remove() will free denali->buf twice
> > because kfree(denali->buf) is called from denali_detach_chip().
>

Absolutely, thanks for reviewing!

I'll apply with this changed.

Miquèl

\
 
 \ /
  Last update: 2018-07-25 14:48    [W:0.074 / U:0.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site