[lkml]   [2018]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 20/20] signal: Don't restart fork when signals come in.
On Tue, Jul 24, 2018 at 1:05 PM Eric W. Biederman <> wrote:
> What I hear you asking is moving up copy_signal copy_sighand copy_creds
> and alloc_pid, and anything else that signal delivery might depend on.

No, _just_ signal allocation.

It would still just use the special-case list to set the pending bit.
No creds, no "full task", nothing like that.

> I really want something very simple and straight forward because I don't
> see us testing or hitting this code path much in practice. Moving this
> into the middle of fork and adding more depedencies does not seem like
> it will be that kind of straight forward.

I think your "list on the stack" was anything but straightforward,
considering how utterly broken the error handling of the patch was.

But hey., send a fixed patch and see how it looks. I think you'll end
up adding a lot of "goto signal_cleanup" cases.


 \ /
  Last update: 2018-07-24 22:16    [W:0.103 / U:3.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site