lkml.org 
[lkml]   [2018]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] omapfb: rename omap2 module to omap2fb.ko
Date
On Monday, July 09, 2018 12:02:16 AM Tony Lindgren wrote:
> * Arnd Bergmann <arnd@arndb.de> [180706 12:39]:
> > In a kernel configuration with both CONFIG_FB_OMAP=m and CONFIG_FB_OMAP2=m,
> > Kbuild fails to point out that we have two modules with the same name (omapfb.ko),
> > but instead fails with a cryptic error message like:
> >
> > ERROR: "omapfb_register_panel" [drivers/video/fbdev/omap/lcd_osk.ko] undefined!
> >
> > This can now happen when building a randconfig kernel with CONFIG_ARCH_OMAP1,
> > as the omap1 fbdev driver depends on that, whiel the omap2 fbdev driver can
> > now be built anywhere with CONFIG_COMPILE_TEST.
> >
> > The solution is to rename one of the two modules, so for consistency with
> > the directory naming I decided to rename the omap2 version to omap2fb.ko.
>
> Sounds good to me:
>
> Acked-by: Tony Lindgren <tony@atomide.com>

Patch queued for 4.19, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

\
 
 \ /
  Last update: 2018-07-24 17:45    [W:0.060 / U:5.808 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site