lkml.org 
[lkml]   [2018]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RESEND] kthread, tracing: Don't expose half-written comm when creating kthreads
From
Date
On 07/24/2018 04:48 PM, Steven Rostedt wrote:
> On Tue, 24 Jul 2018 10:17:37 +0200
> Snild Dolkow <snild@sony.com> wrote:
>
>> creator other
>> vsnprintf:
>> fill (not terminated)
>> count the rest read/use comm
>
> I think it would be better to state what was reading the comm. Like
>
> trace_sched_waking(p)
> memcpy(comm, p->comm, TASK_COMM_LEN)
>
> But the rest looks fine.
>
> -- Steve

Works for me. Reworded v2 coming up soon.

//Snild

\
 
 \ /
  Last update: 2018-07-24 17:03    [W:0.086 / U:32.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site