lkml.org 
[lkml]   [2018]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/2] pinctrl/amd: use byte access to clear irq/wake status bits
On Fri, Jul 20, 2018 at 6:38 PM, Daniel Kurtz <djkurtz@chromium.org> wrote:
> Sounds reasonable. How about:
>
> - /* Clear interrupt.
> - * We must read the pin register again, in case the
> - * value was changed while executing
> - * generic_handle_irq() above.
> + /*
> + * Write-1-to-clear irq/wake status bits in MSByte.
> + * All other bits in this byte are read-only.
> + * This avoids modifying the lower 24-bits
> because they may have
> + * changed while executing generic_handle_irq() above.
> */

That looks good. Thanks

Daniel

\
 
 \ /
  Last update: 2018-07-24 14:29    [W:0.042 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site