lkml.org 
[lkml]   [2018]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 1/9] Makefile: Prepare for using macros for inline asm

* Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

> 2018-06-23 2:22 GMT+09:00 Nadav Amit <namit@vmware.com>:
> > Using macros for inline assembly improves both readability and
> > compilation decisions that are distorted by big assembly blocks that use
> > alternative sections. Compile macros.S and use it to assemble all C
> > files. Currently, only x86 will use it.
> >
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> > Cc: Michal Marek <michal.lkml@markovi.net>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > Cc: x86@kernel.org
> > Cc: linux-kbuild@vger.kernel.org
> > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > Signed-off-by: Nadav Amit <namit@vmware.com>
> > ---
>
>
>
> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
>
>
>
> > Makefile | 9 +++++++--
> > arch/x86/Makefile | 11 +++++++++--
> > arch/x86/kernel/macros.S | 7 +++++++
> > scripts/Kbuild.include | 4 +++-
> > scripts/mod/Makefile | 2 ++
> > 5 files changed, 28 insertions(+), 5 deletions(-)
> > create mode 100644 arch/x86/kernel/macros.S

So this patch appears to break the xtensa cross-build on my system, with an older
version of crosstools:

MODPOST vmlinux.o
/home/mingo/crosstool-korg/bin//gcc-4.9.0-nolibc/xtensa-linux/bin/xtensa-linux-ld:./arch/xtensa/kernel/vmlinux.lds:430:
syntax error
/home/mingo/tip/Makefile:1010: recipe for target 'vmlinux' failed
make[1]: *** [vmlinux] Error 1
make[1]: Leaving directory '/dev/shm/tip/build'
Makefile:146: recipe for target 'sub-make' failed

Thanks,

Ingo

\
 
 \ /
  Last update: 2018-07-24 13:15    [W:0.080 / U:2.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site