lkml.org 
[lkml]   [2018]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] [SUBMITTED 20180724] arm64: fix ACPI dependencies
On Tue, Jul 24, 2018 at 12:21 PM, Will Deacon <will.deacon@arm.com> wrote:
> On Tue, Jul 24, 2018 at 11:54:25AM +0200, Rafael J. Wysocki wrote:
>> On Tue, Jul 24, 2018 at 11:48 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> > Kconfig reports a warning on x86 builds after the ARM64 dependency
>> > was added.
>> >
>> > drivers/acpi/Kconfig:6:error: recursive dependency detected!
>> > drivers/acpi/Kconfig:6: symbol ACPI depends on EFI
>> >
>> > This rephrases the dependency to keep the ARM64 details out of the
>> > shared Kconfig file, so Kconfig no longer gets confused by it.
>> >
>> > For consistency, all three architectures that support ACPI now
>> > select ARCH_SUPPORTS_ACPI in exactly the configuration in which
>> > they allow it. We still need the 'default x86', as each one
>> > wants a different default: default-y on x86, default-n on arm64,
>> > and always-y on ia64.
>> >
>> > Fixes: 5bcd44083a08 ("drivers: acpi: add dependency of EFI for arm64")
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> > ---
>> > v2: use 'select ARCH_SUPPORTS_ACPI' for all three.
>>
>> LGTM
>>
>> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Same here:
>
> Acked-by: Will Deacon <will.deacon@arm.com>
>
> Would it be ok if I take this via the arm64 tree, since that's where the
> warning was introduced?

Yes, it would, from the ACPI side.

\
 
 \ /
  Last update: 2018-07-24 12:24    [W:0.060 / U:5.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site