lkml.org 
[lkml]   [2018]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: WARNING in port_delete
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title></title>
</head>
<body>
<div name="messageBodySection">I agree with that having a C reproducer would be much better.<br />
Now I'm working on it.<br />
I will immediately let you know once I get the C reproducer.<br />
<br />
<br />
Thank you.<br />
<br />
Best regards,<br />
DaeRyong Jeong</div>
<div name="messageReplySection">On 24 Jul 2018, 4:00 PM +0900, Takashi Iwai &lt;tiwai@suse.de&gt;, wrote:<br />
<blockquote type="cite">On Tue, 24 Jul 2018 05:59:56 +0200,<br />
DaeRyong Jeong wrote:<br />
<blockquote type="cite"><br />
I just realized that the crash has been spotted by Syzkaller a few days before.<br />
(https://syzkaller.appspot.com/bug?id=3490860a465e6b39227c6906f0ef2d40ad4d5bb1)<br />
<br />
I'm CC'ing Syzkaller's mailing list.<br /></blockquote>
<br />
It's very likely a false-positive sanity check, and if so, nothing<br />
serious at all. We may simply remove two snd_BUG_ON() lines.<br />
<br />
But I'd love to have a C reproducer to confirm my understanding is<br />
correct...<br />
<br />
<br />
thanks,<br />
<br />
Takashi<br />
<br />
---<br />
--- a/sound/core/seq/seq_ports.c<br />
+++ b/sound/core/seq/seq_ports.c<br />
@@ -272,9 +272,6 @@ static int port_delete(struct snd_seq_client *client,<br />
if (port-&gt;private_free)<br />
port-&gt;private_free(port-&gt;private_data);<br />
<br />
- snd_BUG_ON(port-&gt;c_src.count != 0);<br />
- snd_BUG_ON(port-&gt;c_dest.count != 0);<br />
-<br />
kfree(port);<br />
return 0;<br />
}<br /></blockquote>
</div>
</body>
</html>
\
 
 \ /
  Last update: 2018-07-24 09:16    [W:0.048 / U:6.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site