lkml.org 
[lkml]   [2018]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/4] Staging: octeon-usb: Applying coding style for column width.
From
Date
On Wed, 2018-07-25 at 01:22 +0300, Georgios Tsotsos wrote:
> This patch resolves the warnings as its refereed to TODO list.
> There are also a code style issues that could be resolved via breaking
> down cvmx_usb_poll_channel().

It was better before this change.

If checkpatch caused you to produce this, please
know that checkpatch messages are not dicta and
do not need to be followed if the resultant code
is worse to read.

More likely, it could be nicer to use a separate
function for this block instead.

> Signed-off-by: Georgios Tsotsos <tsotsos@gmail.com>
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index cff5e790b196..0d3ec12788fc 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -2637,12 +2637,14 @@ static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel)
> hcintmsk.u32 = 0;
> hcintmsk.s.chhltdmsk = 1;
> cvmx_usb_write_csr32(usb,
> - CVMX_USBCX_HCINTMSKX(channel, usb->index),
> - hcintmsk.u32);
> + CVMX_USBCX_HCINTMSKX(channel,
> + usb->index),
> + hcintmsk.u32);
> usbc_hcchar.s.chdis = 1;
> cvmx_usb_write_csr32(usb,
> - CVMX_USBCX_HCCHARX(channel, usb->index),
> - usbc_hcchar.u32);
> + CVMX_USBCX_HCCHARX(channel,
> + usb->index),
> + usbc_hcchar.u32);
> return 0;
> } else if (usbc_hcint.s.xfercompl) {
> /*

\
 
 \ /
  Last update: 2018-07-25 03:23    [W:0.063 / U:6.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site