[lkml]   [2018]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: Reminder to review a few patches sent two weeks ago
On Tue, 2018-07-24 at 14:56 -0700, wrote:
> A reminder to review a few patches I had sent last week. Below are the
> links for the patches.

I have no fundamental object to this one, but
the 80 column use is unnecessary and should be
coalesced before it can be applied.


# warn about #if 1
if ($line =~ /^.\s*\#\s*if\s+1\b/) {
"Consider removing the #if 1 and its #endif\n" . $herecurr);


This one has I think too many existing uses of
things like "return -1;"

$ git grep -P "return\s*\-\d+\s*;" | wc -l

How many of these are actually appropriate?

Also, no space is required between return and -1
by c90 and this should use $Int so it should be:

if ($line =~ /\breturn\s*\-\$Int\s*;/) {


 \ /
  Last update: 2018-07-25 02:34    [W:0.045 / U:2.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site