lkml.org 
[lkml]   [2018]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 05/11] touchscreen: elants: Use octal permissions
From
Date
On Mon, 2018-07-23 at 10:18 -0700, Dmitry Torokhov wrote:
> On Mon, Jul 23, 2018 at 03:32:00PM +0200, Greg Kroah-Hartman wrote:
> > On Mon, Jul 23, 2018 at 06:49:20PM +0530, dev-harsh1998 wrote:
> > > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
> > > +static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL);
> > >
> > > WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'.
> > > +static DEVICE_ATTR(update_fw, S_IWUSR, NULL, write_update_fw)
> > >
> > > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
> > > + .dattr = __ATTR(_field, S_IRUGO, \
> > >
> > > Signed-off-by: Harshit Jain <harshitjain6751@gmail.com>
> >
> > This name doesn't match up with the From: line above :(
> >
> > Please fix up and try again.
>
> dtor@dtor-ws:~/kernel/linux-next$ git grep S_IRU | wc -l
> 7605
>
> We either need to run a tree-wide script or leave this alone. FWIW I am
> perfectly fine with either octals or symbolic names so I do not see
> benefit of doing conversion for code that is not known to be broken.

About half of those are in one subsystem (drivers/hwmon)

$ git grep -w S_IRUGO | cut -f1,2 -d'/' | \
sort | uniq -c | sort -rn | head -10 | cat -n
1 3846 drivers/hwmon
2 748 drivers/scsi
3 215 drivers/infiniband
4 168 drivers/usb
5 109 drivers/media
6 106 drivers/input
7 102 drivers/platform
8 101 drivers/misc
9 101 drivers/gpu
10 91 drivers/edac

The generic reason is octal is readable and S_<FOO> is unintelligible.

https://lkml.org/lkml/2016/8/2/1945

\
 
 \ /
  Last update: 2018-07-23 19:26    [W:0.082 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site