lkml.org 
[lkml]   [2018]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 00/19] Fixes for sched/numa_balancing
On Mon, Jul 23, 2018 at 08:09:55AM -0700, Srikar Dronamraju wrote:

> > > sched/numa: Stop multiple tasks from moving to the cpu at the same time
>
> This patch has go-ahead from Mel and Rik and no outstanding comments.

I left it out because it's part of the big xchg() mess.

In particular:

+ if (xchg(&rq->numa_migrate_on, 1))
+ return;
+
+ if (env->best_cpu != -1) {
+ rq = cpu_rq(env->best_cpu);
+ WRITE_ONCE(rq->numa_migrate_on, 0);
+ }

I'm again confused by clearing numa_migrate_on at this point..

> > > sched/numa: Updation of scan period need not be in lock
>
> I didnt see any comments for this apart from an ack from Rik.
> + It thought it was trivial and shouldnt have any side-effect.

Oh, my bad I actually have this one.

\
 
 \ /
  Last update: 2018-07-23 17:23    [W:0.073 / U:3.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site