lkml.org 
[lkml]   [2018]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] block: ioprio: Replace GFP_ATOMIC with GFP_KERNEL in set_task_ioprio()
From
Date
On 2018/07/23 16:18, Christoph Hellwig wrote:
> Looks good,

Looks bad. :-(

SYSCALL_DEFINE3(ioprio_set, int, which, int, who, int, ioprio)
{
(...snipped...)
rcu_read_lock();
(...snipped...)
ret = set_task_ioprio(p, ioprio);
(...snipped...)
rcu_read_unlock();
(...snipped...)
}

>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> But to me it seems that btrfs and maybe ext4 as well would be much
> better off just setting a per-IO priority in the bio.
>
> Any chance yo could look into that?
>

\
 
 \ /
  Last update: 2018-07-23 23:51    [W:0.092 / U:1.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site