lkml.org 
[lkml]   [2018]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 5/6] KVM: X86: Add NMI support to PV IPIs
From
Date
On 20/07/2018 05:53, Wanpeng Li wrote:
>>> - ret = kvm_hypercall3(KVM_HC_SEND_IPI, ipi_bitmap_low, ipi_bitmap_high, vector);
>>> + switch (vector) {
>>> + default:
>>> + icr = APIC_DM_FIXED | vector;
>>> + break;
>>> + case NMI_VECTOR:
>>> + icr = APIC_DM_NMI;
>> I think it would be better to say that KVM interprets NMI_VECTOR and
>> sends the interrupt as APIC_DM_NMI.

It's not KVM, this is arch/x86/kernel/kvm.c so the guest side.

Paolo

> Yeah, in addition, SDM 10.6.1 also mentioned that:
> Delivery mode:
> 100 (NMI) Delivers an NMI interrupt to the target processor or
> processors. The vector information is ignored.

\
 
 \ /
  Last update: 2018-07-20 10:05    [W:0.092 / U:7.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site