lkml.org 
[lkml]   [2018]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1] memory: tegra: Don't invoke Tegra30+ specific memory timing setup on Tegra20
From
Date

On 19/07/18 16:38, Dmitry Osipenko wrote:
> On Thursday, 19 July 2018 18:30:48 MSK Jon Hunter wrote:
>> On 19/07/18 14:24, Dmitry Osipenko wrote:
>>> This fixes irrelevant "tegra-mc 7000f000.memory-controller: no memory
>>> timings for RAM code 0 registered" warning message during of kernels
>>> boot-up on Tegra20.
>>
>> Looking at the tegra20-emc.txt bindings doc [0], the 'nvidia,ram-code'
>> property is also valid for Tegra20. In fact, I see this warning on the
>> Tegra30 Cardhu because this property is not populated. So I think that
>> this warning is valid and harmless.
>>
>> Cheers
>> Jon
>>
>> [0] Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-emc.txt
>
> That is the irrelevant binding, the relevant one for this driver is [0]. The
> warning is valid for T30+, but not for T20.
>
> [0] Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-mc.txt

Yes indeed, looks like we never supported this for Tegra20. OK, fine with me
I guess this was introduced during the consolidation of the MC drivers. Can
you add the appropriate fixes tag?

Otherwise ...

Acked-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

--
nvpublic

\
 
 \ /
  Last update: 2018-07-20 10:02    [W:0.081 / U:5.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site