lkml.org 
[lkml]   [2018]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH V2] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP
Hi,

On Fri, Jul 20, 2018 at 3:53 PM, Doug Anderson <dianders@chromium.org> wrote:
>> + mas->oversampling = 1;
>> + /* Transmit an entire FIFO worth of data per IRQ */
>> + mas->tx_wm = 1;
>> + geni_se_get_wrapper_version(se, major, minor, step);
>
> In v1 Stephen said:
>
>> Drop extra parenthesis.
>
> I'll further add that I'd prefer it if you based your series atop
> <https://patchwork.kernel.org/patch/10412417/> which changes the
> prototype here.

Whoops. Extra parenthesis was actually referring to the line below
this one, AKA:


> + if ((major == 1) && (minor == 0))
> + mas->oversampling = 2;

...that still applies. ...but then ignore my comment suggesting that
you base your series atop Stephen's. You already did that. Certainly
you should mention somewhere in your email that your patch is based on
his.


-Doug

\
 
 \ /
  Last update: 2018-07-21 01:33    [W:0.060 / U:27.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site