lkml.org 
[lkml]   [2018]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/10] psi: pressure stall information for CPU, memory, and IO
On Thu, Jul 19, 2018 at 02:47:40PM -0400, Johannes Weiner wrote:
> On Wed, Jul 18, 2018 at 02:03:18PM +0200, Peter Zijlstra wrote:
> > On Thu, Jul 12, 2018 at 01:29:40PM -0400, Johannes Weiner wrote:
> > > + /* Update task counts according to the set/clear bitmasks */
> > > + for (to = 0; (bo = ffs(clear)); to += bo, clear >>= bo) {
> > > + int idx = to + (bo - 1);
> > > +
> > > + if (tasks[idx] == 0 && !psi_bug) {
> > > + printk_deferred(KERN_ERR "psi: task underflow! cpu=%d idx=%d tasks=[%u %u %u] clear=%x set=%x\n",
> > > + cpu, idx, tasks[0], tasks[1], tasks[2],
> > > + clear, set);
> > > + psi_bug = 1;
> > > + }
> >
> > WARN_ONCE(!tasks[idx], ...);
>
> It's just open-coded because of the printk_deferred, since this is
> inside the scheduler.

Yeah, meh. There's ton of WARNs in the scheduler, WARNs should not
trigger anyway. But yeah printk is crap, which is why I don't use printk
anymore:

https://lkml.kernel.org/r/20170928121823.430053219@infradead.org


\
 
 \ /
  Last update: 2018-07-19 22:32    [W:0.114 / U:5.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site