lkml.org 
[lkml]   [2018]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] net: dsa: Remove VLA usage
From
From: Andrew Lunn <andrew@lunn.ch>
Date: Wed, 18 Jul 2018 22:37:25 +0200

> On Thu, Jul 19, 2018 at 05:33:33AM +0900, David Miller wrote:
>> From: Kees Cook <keescook@chromium.org>
>> Date: Mon, 16 Jul 2018 21:10:34 -0700
>>
>> > From: Salvatore Mesoraca <s.mesoraca16@gmail.com>
>> >
>> > We avoid 2 VLAs by using a pre-allocated field in dsa_switch. We also
>> > try to avoid dynamic allocation whenever possible (when using fewer than
>> > bits-per-long ports, which is the common case).
>> >
>> > Link: http://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
>> > Link: http://lkml.kernel.org/r/20180505185145.GB32630@lunn.ch
>> > Signed-off-by: Salvatore Mesoraca <s.mesoraca16@gmail.com>
>> > [kees: tweak commit subject and message slightly]
>> > Signed-off-by: Kees Cook <keescook@chromium.org>
>>
>> Florian and Andrew, please review.
>
> Last time there was some discussion of just always allocating it to
> make the code simpler. But the extra complexity is O.K.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Great, applied, thanks!

\
 
 \ /
  Last update: 2018-07-19 00:09    [W:0.049 / U:3.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site