lkml.org 
[lkml]   [2018]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] binfmt_elf: Respect error return from `regset->active'
Hi Paul,

> > --- linux-jhogan-test.orig/fs/binfmt_elf.c 2018-03-21 17:14:55.000000000 +0000
> > +++ linux-jhogan-test/fs/binfmt_elf.c 2018-05-09 23:25:50.742255000 +0100
> > @@ -1739,7 +1739,7 @@ static int fill_thread_core_info(struct
> > const struct user_regset *regset = &view->regsets[i];
> > do_thread_regset_writeback(t->task, regset);
> > if (regset->core_note_type && regset->get &&
> > - (!regset->active || regset->active(t->task, regset))) {
> > + (!regset->active || regset->active(t->task, regset) > 0)) {
> > int ret;
> > size_t size = regset_size(t->task, regset);
> > void *data = kmalloc(size, GFP_KERNEL);
> >
>
> This looks obviously right to me, although I don't think it affects
> anything until commit 25847fb195ae ("powerpc/ptrace: Enable support for
> NT_PPC_CGPR") in v4.8-rc1 & even then not in a harmful way so I'd drop
> the stable tag.

I'm fine with dropping the tag FWIW. Thanks for taking care of my patch.

Maciej

\
 
 \ /
  Last update: 2018-07-16 07:45    [W:0.102 / U:1.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site