lkml.org 
[lkml]   [2018]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/8] efi/x86: Use non-blocking SetVariable() for efi_delete_dummy_variable()

* Prakhya, Sai Praneeth <sai.praneeth.prakhya@intel.com> wrote:

> > > diff --git a/arch/x86/platform/efi/quirks.c
> > > b/arch/x86/platform/efi/quirks.c index 36c1f8b9f7e0..6af39dc40325
> > > 100644
> > > --- a/arch/x86/platform/efi/quirks.c
> > > +++ b/arch/x86/platform/efi/quirks.c
> > > @@ -105,12 +105,11 @@ early_param("efi_no_storage_paranoia",
> > > setup_storage_paranoia); */ void efi_delete_dummy_variable(void) {
> > > - efi.set_variable((efi_char16_t *)efi_dummy_name,
> > > - &EFI_DUMMY_GUID,
> > > - EFI_VARIABLE_NON_VOLATILE |
> > > - EFI_VARIABLE_BOOTSERVICE_ACCESS |
> > > - EFI_VARIABLE_RUNTIME_ACCESS,
> > > - 0, NULL);
> > > + efi.set_variable_nonblocking((efi_char16_t *)efi_dummy_name,
> > > + &EFI_DUMMY_GUID,
> > > + EFI_VARIABLE_NON_VOLATILE |
> > > + EFI_VARIABLE_BOOTSERVICE_ACCESS |
> > > + EFI_VARIABLE_RUNTIME_ACCESS, 0, NULL);
> > > }
> >
> > Just wondering, what is the full stack trace of the splat? It sounds a bit surprising
> > to me that such type of EFI code is used from the idle thread.
>
> Sorry! for the confusing commit message. Kernel warns about scheduling from idle
> thread only when "efi_rts_wq" is used to invoke efi_runtime_services(). So,
> presently, this doesn't happen on mainline kernel. Support for "efi_rts_wq" is
> added by commit 3eb420e70d87 (efi: Use a work queue to invoke EFI Runtime
> Services).

Ok, that makes a lot more sense!

Thanks,

Ingo

\
 
 \ /
  Last update: 2018-07-16 03:03    [W:0.051 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site