[lkml]   [2018]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] checkpatch: Fix macro argument reuse test
Multiple line macro definitions where the arguments are
separated by line continuations can cause checkpatch to
emit invalid syntax regex tests.

This can occur when a single argument is modified in a
part of a patch.

For example: (to not add a diff in the commit message)

$ ./scripts/ --git db023296f0115d2fe01fdabad54678f2b806da23
Unterminated \g... pattern in regex; <very long regex omitted>

And, the test does not work correctly when these arguments
are all new as the initial patch line addition "+" is used
in the argument name.

Fix this by stripping the line continuations and any "+"
from the list of arguments.

Signed-off-by: Joe Perches <>
scripts/ | 1 +
1 file changed, 1 insertion(+)

diff --git a/scripts/ b/scripts/
index b5c875d7132b..fa29aebff5a1 100755
--- a/scripts/
+++ b/scripts/
@@ -4950,6 +4950,7 @@ sub process {
if (defined $define_args && $define_args ne "") {
$define_args = substr($define_args, 1, length($define_args) - 2);
$define_args =~ s/\s*//g;
+ $define_args =~ s/\\\+?//g;
@def_args = split(",", $define_args);
 \ /
  Last update: 2018-07-15 22:07    [W:0.028 / U:0.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site