[lkml]   [2018]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 11/18] staging: gasket: always allow root open for write
On Sat, Jul 14, 2018 at 8:58 AM Todd Poynor <> wrote:
> From: Todd Poynor <>
> Always allow root to open device for writing.
> Drop special-casing of ioctl permissions for root vs. owner.
> Reported-by: Dmitry Torokhov <>
> Signed-off-by: Zhongze Hu <>
> Signed-off-by: Todd Poynor <>

I think this patch is good as is, but as a followup you should create
a patch that supports user namespaces, i.e. replaces
capable(CAP_SYS_ADMIN) with ns_capable(...) in gasket_open() so you
can allow containers to control the device, if necessary.

Reviewed-by: Dmitry Torokhov <>

 \ /
  Last update: 2018-07-15 22:07    [W:0.184 / U:0.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site