lkml.org 
[lkml]   [2018]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 14/18] staging: gasket: fix class create bug handling
On Sat, Jul 14, 2018 at 8:59 AM Todd Poynor <toddpoynor@gmail.com> wrote:
>
> From: Todd Poynor <toddpoynor@google.com>
>
> class_create() never returns NULL, and this driver should never return
> PTR_ERR(NULL) anyway.
>
> Reported-by: Dmitry Torokhov <dtor@chromium.org>
> Signed-off-by: Zhongze Hu <frankhu@chromium.org>
> Signed-off-by: Todd Poynor <toddpoynor@google.com>

Reviewed-by: Dmitry Torokhov <dtor@chromium.org>

> ---
> drivers/staging/gasket/gasket_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c
> index f7d8f66e8746..0ef37667e0f1 100644
> --- a/drivers/staging/gasket/gasket_core.c
> +++ b/drivers/staging/gasket/gasket_core.c
> @@ -341,7 +341,7 @@ int gasket_register_device(const struct gasket_driver_desc *driver_desc)
> internal->class =
> class_create(driver_desc->module, driver_desc->name);
>
> - if (IS_ERR_OR_NULL(internal->class)) {
> + if (IS_ERR(internal->class)) {
> gasket_nodev_error("Cannot register %s class [ret=%ld]",
> driver_desc->name, PTR_ERR(internal->class));
> ret = PTR_ERR(internal->class);
> --
> 2.18.0.203.gfac676dfb9-goog
>
\
 
 \ /
  Last update: 2018-07-15 22:07    [W:0.212 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site